> On May 11, 2016, 9:11 a.m., Michael Park wrote: > > 3rdparty/libprocess/include/Makefile.am, line 48 > > <https://reviews.apache.org/r/46423/diff/4/?file=1373532#file1373532line48> > > > > This should be `process/posix/subprocess.hpp`
Huh. I wonder how this happened. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46423/#review132625 ----------------------------------------------------------- On May 5, 2016, 3:35 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46423/ > ----------------------------------------------------------- > > (Updated May 5, 2016, 3:35 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3637 > https://issues.apache.org/jira/browse/MESOS-3637 > > > Repository: mesos > > > Description > ------- > > Windows: Forked subprocess.cpp, added `Windows` implementation. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am c51c31eb91dd7be4cff8a188942ea77b3b361d45 > 3rdparty/libprocess/include/Makefile.am > 47f5347988a61140c87bcd329e25d5a4d52e17a0 > 3rdparty/libprocess/include/process/posix/subprocess.hpp PRE-CREATION > 3rdparty/libprocess/include/process/subprocess.hpp > 6ce1a827e36e0c65985e3928c89f51561fdd70cd > 3rdparty/libprocess/include/process/subprocess_base.hpp PRE-CREATION > 3rdparty/libprocess/include/process/windows/subprocess.hpp PRE-CREATION > 3rdparty/libprocess/src/CMakeLists.txt > a8379d323f30037bdd15e151957f885664b5e242 > 3rdparty/libprocess/src/subprocess.cpp > bb0fcbcd0dfa455c8700247c5b4ca0473fd163c3 > 3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION > 3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46423/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >