----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47198/#review132879 -----------------------------------------------------------
include/mesos/docker/v1.proto (lines 56 - 57) <https://reviews.apache.org/r/47198/#comment197155> Why both `optional`? I found that other `Label` definition are defining `key` as required but `value` as `optional` or `required`. I think that for your case, both `key` and `value` should be required? - Guangya Liu On 五月 12, 2016, 3:56 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47198/ > ----------------------------------------------------------- > > (Updated 五月 12, 2016, 3:56 a.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, and Kevin > Klues. > > > Bugs: MESOS-5272 > https://issues.apache.org/jira/browse/MESOS-5272 > > > Repository: mesos > > > Description > ------- > > Added labels to docker v1 spec config. > > > Diffs > ----- > > include/mesos/docker/v1.proto ff18f8cadfce3315467f194d50d3469fa839f686 > > Diff: https://reviews.apache.org/r/47198/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
