----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47266/#review132778 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 312) <https://reviews.apache.org/r/47266/#comment197031> Maybe add a comment over here as to what the .wh. files are meant for? I think for someone who does not have that context it will be hard to understand what the .wh. files are used for. src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 319) <https://reviews.apache.org/r/47266/#comment197025> s/one-layer image/single-layered images s/exclude/excludes s/using bind/using the bind src/slave/containerizer/mesos/provisioner/provisioner.cpp (lines 334 - 353) <https://reviews.apache.org/r/47266/#comment197282> Just a thought, this looks like a `find` function that might be very useful in stout? Should we implement a `find` in stout using fts and wrap this code into a function that returns a `Result` ? src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 348) <https://reviews.apache.org/r/47266/#comment197283> I think this should be: Failure( "Failed to ..... src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 364) <https://reviews.apache.org/r/47266/#comment197284> Ditto on code style. src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 370) <https://reviews.apache.org/r/47266/#comment197285> Ditto on code-style. - Avinash sridharan On May 11, 2016, 10:46 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47266/ > ----------------------------------------------------------- > > (Updated May 11, 2016, 10:46 p.m.) > > > Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, and > Timothy Chen. > > > Bugs: MESOS-5277 > https://issues.apache.org/jira/browse/MESOS-5277 > > > Repository: mesos > > > Description > ------- > > Implemented provisioner removing docker whitelist files. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/provisioner.hpp > 5c96e9f6603d39889e6bc807874d35d0cb3556be > src/slave/containerizer/mesos/provisioner/provisioner.cpp > dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 > > Diff: https://reviews.apache.org/r/47266/diff/ > > > Testing > ------- > > make check > > Tested with docker image containing `.wh.` files. > > > Thanks, > > Gilbert Song > >
