> On May 12, 2016, 11:33 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp, line 375 > > <https://reviews.apache.org/r/47266/diff/1/?file=1380178#file1380178line375> > > > > You seem to only fts_close on error cases, but in the normal case > > skipped to do so. > > Guangya Liu wrote: > @tnachen, I also found a similar issue for xfs isolator and posted a > patch here https://reviews.apache.org/r/37257/ , can you help review? Thanks.
Thanks, Tim! Good catch! - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47266/#review133039 ----------------------------------------------------------- On May 11, 2016, 3:46 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47266/ > ----------------------------------------------------------- > > (Updated May 11, 2016, 3:46 p.m.) > > > Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, and > Timothy Chen. > > > Bugs: MESOS-5277 > https://issues.apache.org/jira/browse/MESOS-5277 > > > Repository: mesos > > > Description > ------- > > Implemented provisioner removing docker whitelist files. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/provisioner.hpp > 5c96e9f6603d39889e6bc807874d35d0cb3556be > src/slave/containerizer/mesos/provisioner/provisioner.cpp > dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 > > Diff: https://reviews.apache.org/r/47266/diff/ > > > Testing > ------- > > make check > > Tested with docker image containing `.wh.` files. > > > Thanks, > > Gilbert Song > >
