> On 五月 12, 2016, 10:47 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/provisioner/appc/store.cpp, lines 217-233 > > <https://reviews.apache.org/r/44839/diff/2/?file=1348001#file1348001line217> > > > > Do we have a way to optimize the logic here?
Did not found a good way to optimize the logic here, but I think that current logic is good enough to understand, what do you think? - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44839/#review132995 ----------------------------------------------------------- On 四月 18, 2016, 8:31 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44839/ > ----------------------------------------------------------- > > (Updated 四月 18, 2016, 8:31 a.m.) > > > Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu. > > > Bugs: MESOS-4886 > https://issues.apache.org/jira/browse/MESOS-4886 > > > Repository: mesos > > > Description > ------- > > Enabled mesos containerizer force_pull_image for appc. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/appc/store.cpp > 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 > > Diff: https://reviews.apache.org/r/44839/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
