----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44839/#review134437 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 69) <https://reviews.apache.org/r/44839/#comment199247> per my comments in the previous patch, please `s/forcePullImage/cached/` src/slave/containerizer/mesos/provisioner/appc/store.cpp (lines 220 - 229) <https://reviews.apache.org/r/44839/#comment199246> ``` Option<string> imageId = appc.has_id() ? appc.id() : cache->find(appc); if (cached && imageId.isSome()) { if (os::exists(...)) { ... } } return _fetchImage(appc) .then(defer(self(), ...)); ``` - Jie Yu On May 21, 2016, 1:32 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44839/ > ----------------------------------------------------------- > > (Updated May 21, 2016, 1:32 a.m.) > > > Review request for mesos, Gilbert Song, haosdent huang, and Jie Yu. > > > Bugs: MESOS-4886 > https://issues.apache.org/jira/browse/MESOS-4886 > > > Repository: mesos > > > Description > ------- > > Enabled mesos containerizer force_pull_image for appc. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/appc/store.cpp > 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 > > Diff: https://reviews.apache.org/r/44839/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
