----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47339/#review133075 -----------------------------------------------------------
src/slave/http.cpp (line 838) <https://reviews.apache.org/r/47339/#comment197366> Let's do the same in the master. src/slave/http.cpp (lines 845 - 846) <https://reviews.apache.org/r/47339/#comment197362> Fits one line now. src/slave/slave.hpp (line 475) <https://reviews.apache.org/r/47339/#comment197363> `static`? src/slave/slave.hpp (lines 475 - 483) <https://reviews.apache.org/r/47339/#comment197365> Why these functions are in the "continuations" sections? Please move them below _statistics() and feel free to prepend them with `// Helper routines. src/slave/slave.hpp (lines 477 - 480) <https://reviews.apache.org/r/47339/#comment197364> The comment is outdated now. You can take the one from `Master::Http::authorizeEndpoint()` as an example. - Alexander Rukletsov On May 13, 2016, 9:14 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47339/ > ----------------------------------------------------------- > > (Updated May 13, 2016, 9:14 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > Extracting the HTTP endpoint from `URL.path` is now done in a separate > function in `Slave::Http`, making `Slave::Http::extractEndpoint` > consistent with the one in `Master::Http`. > > > Diffs > ----- > > src/slave/http.cpp db60a243c6f099c3a4cfe2503ef4a4c8d57354ce > src/slave/slave.hpp be622d31de29a242a6c71fd8dedb06aeff19142d > > Diff: https://reviews.apache.org/r/47339/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
