> On May 13, 2016, 10:47 a.m., Alexander Rukletsov wrote: > > src/slave/slave.hpp, line 475 > > <https://reviews.apache.org/r/47339/diff/1/?file=1382449#file1382449line475> > > > > `static`? > > Jan Schlicht wrote: > The function uses `slave->this().id` so it would be a bit inconvenient to > make it static.
I see. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47339/#review133075 ----------------------------------------------------------- On May 13, 2016, 9:14 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47339/ > ----------------------------------------------------------- > > (Updated May 13, 2016, 9:14 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > Extracting the HTTP endpoint from `URL.path` is now done in a separate > function in `Slave::Http`, making `Slave::Http::extractEndpoint` > consistent with the one in `Master::Http`. > > > Diffs > ----- > > src/slave/http.cpp db60a243c6f099c3a4cfe2503ef4a4c8d57354ce > src/slave/slave.hpp be622d31de29a242a6c71fd8dedb06aeff19142d > > Diff: https://reviews.apache.org/r/47339/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
