----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46498/#review133390 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp (line 953) <https://reviews.apache.org/r/46498/#comment197768> It would be readable if we separat the two `if` blocks with a blanlk line. src/slave/containerizer/mesos/isolators/appc/runtime.hpp (line 26) <https://reviews.apache.org/r/46498/#comment197770> s/APPC/AppC? Please look for more occurrences. src/slave/containerizer/mesos/isolators/appc/runtime.hpp (line 29) <https://reviews.apache.org/r/46498/#comment197774> s/Appc/AppC as Guangya proposed? src/slave/containerizer/mesos/isolators/appc/runtime.hpp (lines 64 - 73) <https://reviews.apache.org/r/46498/#comment197786> Do these need to be member functions? Could they be functions in `cpp` file? src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 50) <https://reviews.apache.org/r/46498/#comment197777> No need to wrap to newline. It fits within 80 chars. src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 147) <https://reviews.apache.org/r/46498/#comment197787> blank line above. src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 171) <https://reviews.apache.org/r/46498/#comment197788> blank line above. src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 174) <https://reviews.apache.org/r/46498/#comment197789> blank line above src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 246) <https://reviews.apache.org/r/46498/#comment197791> I think you should use `string::empty` src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 201) <https://reviews.apache.org/r/46498/#comment197795> Do you need this variable? src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 203) <https://reviews.apache.org/r/46498/#comment197796> I think you just need the base image manifest here and not all the manifests. Right? - Jojy Varghese On May 14, 2016, 4:20 a.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46498/ > ----------------------------------------------------------- > > (Updated May 14, 2016, 4:20 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese. > > > Repository: mesos > > > Description > ------- > > Add runtime for Appc Spec ex: command, workingdir and environment. > > > Diffs > ----- > > include/mesos/appc/spec.proto 4ef0473748c2f47aff1729c1d969185803fe72d4 > include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 > src/Makefile.am 447bc2ab511ad173d3d911be10992be0974f4584 > src/slave/containerizer/mesos/containerizer.cpp > 75e5a32a3e70ec60a6800e21a621673184ea0956 > src/slave/containerizer/mesos/isolators/appc/runtime.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION > src/slave/containerizer/mesos/provisioner/appc/store.cpp > 33e97fc645a9b7fbc9ae47f67c1b5dacf999fce0 > src/slave/containerizer/mesos/provisioner/provisioner.hpp > 5c96e9f6603d39889e6bc807874d35d0cb3556be > src/slave/containerizer/mesos/provisioner/provisioner.cpp > dcbbbaf797d4467bfd0bb1ee91ee9ce843e7d546 > src/slave/containerizer/mesos/provisioner/store.hpp > 1d477ef13ddd24fd8badae0decaa4a2271ecc746 > src/tests/containerizer/provisioner_appc_tests.cpp > 84fe52b6937c3b7d7628b17a2f045eec2f386b4d > > Diff: https://reviews.apache.org/r/46498/diff/ > > > Testing > ------- > > > Thanks, > > Srinivas Brahmaroutu > >
