-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46892/#review133601
-----------------------------------------------------------




src/docker/executor.cpp (line 308)
<https://reviews.apache.org/r/46892/#comment198147>

    `.await()` blocks the execution and synchronously wait for docker to 
terminate. I'd expect that during this period the docker executor won't be 
responsive to anything, like escalating kills. Moreover, I'd expect that 
`TASK_KILLING` won't be sent by the driver since we are blocked in the callback.
    
    If I understand your intention correctly, you want to discard `run` only 
after the container terminates. This is what `reaped()` callbakc is for: it is 
invoked when the container terminates, i.e. `stop` has signaled.
    
    My only concern about discarding `run` in `reaped()` is for the case when 
docker container is starting but has not yet started. I would like us to test 
this case.



src/docker/executor.cpp (line 358)
<https://reviews.apache.org/r/46892/#comment198150>

    Why this change?


- Alexander Rukletsov


On May 17, 2016, 6:15 p.m., Martin Bydzovsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46892/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 6:15 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4279
>     https://issues.apache.org/jira/browse/MESOS-4279
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 579905f6c2ece7db9c853abf481541fdbc3116b7 
> 
> Diff: https://reviews.apache.org/r/46892/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Bydzovsky
> 
>

Reply via email to