> On Kvě. 17, 2016, 7:24 odp., Alexander Rukletsov wrote:
> > src/docker/executor.cpp, line 358
> > <https://reviews.apache.org/r/46892/diff/1/?file=1368337#file1368337line358>
> >
> >     Why this change?

Geeez, do I really have to repeat myself milion times? Without this change, the 
killed/finished task - however you call it ( = ended task) - would end up in 
TASK_FAILED state = which is obviously the biggest bullshit. And again (I'm 
saying this for like fifth time) - when you GRACEFULLY STOP non-docker task - 
by sending sigterm from the driver - it ends in FINISHED STATE (as i showed in 
the goddman video - has even anyone watched it?!) - not KILLED. So you are 
purposing to create inconsistency between docker and non-docker executor. 
Should i rewrite the non-docker executor too?? to synchronize it? I guess not.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46892/#review133601
-----------------------------------------------------------


On Kvě. 17, 2016, 6:15 odp., Martin Bydzovsky wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46892/
> -----------------------------------------------------------
> 
> (Updated Kvě. 17, 2016, 6:15 odp.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4279
>     https://issues.apache.org/jira/browse/MESOS-4279
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.cpp 579905f6c2ece7db9c853abf481541fdbc3116b7 
> 
> Diff: https://reviews.apache.org/r/46892/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Bydzovsky
> 
>

Reply via email to