-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46369/#review133858
-----------------------------------------------------------


Fix it, then Ship it!





include/mesos/mesos.proto (line 1734)
<https://reviews.apache.org/r/46369/#comment198506>

    Remove the extra space before the text.



include/mesos/mesos.proto (line 1739)
<https://reviews.apache.org/r/46369/#comment198507>

    Could you please add a NOTE here about why we want to start the tag number 
from 1000? Also, can you add an INVALID=0?


- Jie Yu


On May 11, 2016, 4:27 a.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46369/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 4:27 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-5232
>     https://issues.apache.org/jira/browse/MESOS-5232
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added capabilities support in ContanerInfo protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 9a180304996895e2e003085690a7dff9ec561e9c 
>   include/mesos/v1/mesos.proto 44b4f8a059f9dfdcbf02f0c30c1b859898c2e617 
> 
> Diff: https://reviews.apache.org/r/46369/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Reply via email to