----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47671/#review134216 -----------------------------------------------------------
Patch looks great! Reviews applied: [47473, 47492, 47486, 47474, 47489, 47442, 47670, 47671] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On May 20, 2016, 10:14 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47671/ > ----------------------------------------------------------- > > (Updated May 20, 2016, 10:14 p.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris > Van Remoortere, and Michael Park. > > > Bugs: MESOS-5428 > https://issues.apache.org/jira/browse/MESOS-5428 > > > Repository: mesos > > > Description > ------- > > Windows: [2/2] Used `initialize()` in FlagsBase's derived classes. > > > Diffs > ----- > > src/exec/exec.cpp 69a1fb256fe3005e814833ecac5a5a642b585510 > src/executor/executor.cpp fd2d0cd64956b5a407e37ddaa1e9e35c1456d57b > src/launcher/fetcher.cpp 0539b0182bd4a7178f103dddd1ab4fee8fc79eda > src/logging/flags.hpp fe40a11c6a5e3ef44ecf008d1aa03d4e74e59859 > src/logging/flags.cpp db8fd3e0328f0f8be6968e58b173ce4c11c8adcb > src/slave/flags.hpp 3363412099ca2841e175bd6b6ed3d5f13605e6f0 > src/slave/flags.cpp 2d59329997197966f7d30d6f1375a988edbceb9c > src/slave/main.cpp 13ddfb9ae5a1ca240b738e67391ce5c5fc9ac0b6 > > Diff: https://reviews.apache.org/r/47671/diff/ > > > Testing > ------- > > OSX make check > > > Thanks, > > Daniel Pravat > >
