----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47671/#review134242 -----------------------------------------------------------
Patch looks great! Reviews applied: [47473, 47492, 47486, 47474, 47489, 47442, 47671] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On May 21, 2016, 4:52 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47671/ > ----------------------------------------------------------- > > (Updated May 21, 2016, 4:52 p.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris > Van Remoortere, and Michael Park. > > > Bugs: MESOS-5428 > https://issues.apache.org/jira/browse/MESOS-5428 > > > Repository: mesos > > > Description > ------- > > Windows: Removed the virtual inheritance in FlagsBase use. > > > Diffs > ----- > > src/logging/flags.hpp fe40a11c6a5e3ef44ecf008d1aa03d4e74e59859 > > Diff: https://reviews.apache.org/r/47671/diff/ > > > Testing > ------- > > OSX make check > > > Thanks, > > Daniel Pravat > >
