> On April 9, 2016, 7:08 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 757 > > <https://reviews.apache.org/r/45958/diff/1/?file=1337790#file1337790line757> > > > > What about `ShareableInfo`? This is also consistent with > > `RevocableInfo`. > > Anindya Sinha wrote: > I am not sure if that is a huge deal though. I would prefer to keep it as > ShareInfo, but if there is a strong opinion regarding this I am open to > change this to ShareableInfo.
Updated to SharedInfo > On April 9, 2016, 7:08 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 762 > > <https://reviews.apache.org/r/45958/diff/1/?file=1337790#file1337790line762> > > > > s/optional ShareInfo share/optional ShareableInfo shareable > > Anindya Sinha wrote: > Will change as appropriate. Updated to `optional SharedInfo shared`. - Anindya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45958/#review127960 ----------------------------------------------------------- On April 29, 2016, 12:15 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45958/ > ----------------------------------------------------------- > > (Updated April 29, 2016, 12:15 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-4892 > https://issues.apache.org/jira/browse/MESOS-4892 > > > Repository: mesos > > > Description > ------- > > Added ShareInfo in Resource protobuf to allow for sharing of resources. > > > Diffs > ----- > > include/mesos/mesos.proto 9a180304996895e2e003085690a7dff9ec561e9c > include/mesos/v1/mesos.proto 44b4f8a059f9dfdcbf02f0c30c1b859898c2e617 > > Diff: https://reviews.apache.org/r/45958/diff/ > > > Testing > ------- > > Tests successful. > > > Thanks, > > Anindya Sinha > >
