----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review134277 -----------------------------------------------------------
support/docker_build.sh (line 126) <https://reviews.apache.org/r/45668/#comment199016> Don't think we need to have the `replace` variable. Just use the replacement strings inline. Also need periods at the end of comments and quotes around literals. # Remove "'". CONFIGURATION=${CONFIGURATION//\'/} support/docker_build.sh (line 129) <https://reviews.apache.org/r/45668/#comment199017> # Remove "\". CONFIGURATION=${CONFIGURATION//\/} Do we have back slashes in configuration? support/docker_build.sh (line 131) <https://reviews.apache.org/r/45668/#comment199018> # Replace "-" with "_". CONFIGURATION=${CONFIGURATION//-/_} support/docker_build.sh (line 134) <https://reviews.apache.org/r/45668/#comment199019> Shouldn't this be "--" instead of "__" ? # Replace "--" with "-D". CONFIGURATION=${CONFIGURATION//--/-D} support/docker_build.sh (line 137) <https://reviews.apache.org/r/45668/#comment199020> # To upper case. support/docker_build.sh (line 140) <https://reviews.apache.org/r/45668/#comment199021> # Add "=1" suffix to each variable. support/docker_build.sh (line 146) <https://reviews.apache.org/r/45668/#comment199022> kill this? support/docker_build.sh (line 150) <https://reviews.apache.org/r/45668/#comment199023> "distcheck" - Vinod Kone On May 22, 2016, 2:10 p.m., Juan Larriba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45668/ > ----------------------------------------------------------- > > (Updated May 22, 2016, 2:10 p.m.) > > > Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone. > > > Bugs: MESOS-5101 > https://issues.apache.org/jira/browse/MESOS-5101 > > > Repository: mesos > > > Description > ------- > > Enable CMake build > > > Diffs > ----- > > support/docker_build.sh 28ef4dce3f473adab9919d4c2170075a0900af41 > > Diff: https://reviews.apache.org/r/45668/diff/ > > > Testing > ------- > > Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both > cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in > centos:7 only gcc. > > > Thanks, > > Juan Larriba > >
