> On May 22, 2016, 5:26 p.m., Vinod Kone wrote: > >
Also you need a "." in the summary of the review to make reviewbot happy. > On May 22, 2016, 5:26 p.m., Vinod Kone wrote: > > support/docker_build.sh, line 134 > > <https://reviews.apache.org/r/45668/diff/7/?file=1390779#file1390779line134> > > > > Shouldn't this be "--" instead of "__" ? > > > > # Replace "--" with "-D". > > CONFIGURATION=${CONFIGURATION//--/-D} > > Juan Larriba wrote: > We have just replaced all "-" with "_" in the previous step. I see. Lets do "--" transformation first so that it doesn't affect "-" transformation? - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45668/#review134277 ----------------------------------------------------------- On May 22, 2016, 6:38 p.m., Juan Larriba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45668/ > ----------------------------------------------------------- > > (Updated May 22, 2016, 6:38 p.m.) > > > Review request for mesos, Alex Clemmer, Joerg Schad, and Vinod Kone. > > > Bugs: MESOS-5101 > https://issues.apache.org/jira/browse/MESOS-5101 > > > Repository: mesos > > > Description > ------- > > Enable CMake build with autotools configuration. > > > Diffs > ----- > > support/docker_build.sh 28ef4dce3f473adab9919d4c2170075a0900af41 > > Diff: https://reviews.apache.org/r/45668/diff/ > > > Testing > ------- > > Built using docker_build.sh on both centos:7 and ubuntu:14.04 using both > cmake and autotools. In ubuntu:14.04 was built using gcc and clang, in > centos:7 only gcc. > > > Thanks, > > Juan Larriba > >
