----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47259/#review134829 -----------------------------------------------------------
src/master/allocator/sorter/drf/sorter.cpp (line 50) <https://reviews.apache.org/r/47259/#comment199755> Why can this be a `CHECK` if the previous review can't? What is the standard we're trying to set for invariants? - Joris Van Remoortere On May 19, 2016, 6:28 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47259/ > ----------------------------------------------------------- > > (Updated May 19, 2016, 6:28 p.m.) > > > Review request for mesos, Dario Rexin and Joris Van Remoortere. > > > Bugs: MESOS-5279 > https://issues.apache.org/jira/browse/MESOS-5279 > > > Repository: mesos > > > Description > ------- > > CHECK if DRFSorter::add() would introduce a duplicate. > > > Diffs > ----- > > src/master/allocator/sorter/drf/sorter.cpp > 4306973277b9d32356eed31ceabac09fb2a03e6c > > Diff: https://reviews.apache.org/r/47259/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
