> On May 11, 2016, 10:39 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 149 > > <https://reviews.apache.org/r/47078/diff/2/?file=1375600#file1375600line149> > > > > make this `const Option<T2>&` instead?
Per our discussion, I'm going to stick with `T2*` due to problems passing string literals when using `Option`. I added a comment to this effect, and linked a JIRA. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47078/#review132766 ----------------------------------------------------------- On May 27, 2016, 11:29 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47078/ > ----------------------------------------------------------- > > (Updated May 27, 2016, 11:29 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-5064 > https://issues.apache.org/jira/browse/MESOS-5064 > > > Repository: mesos > > > Description > ------- > > Added checking for required flags to FlagsBase. > > > Diffs > ----- > > 3rdparty/stout/include/stout/flags/flag.hpp > 9be35c61c4f40b4bb9e7bcb29e07ae8b35f6e20b > 3rdparty/stout/include/stout/flags/flags.hpp > 91542f56431579be8a3da5ec6e3e58f68e7dfcbe > > Diff: https://reviews.apache.org/r/47078/diff/ > > > Testing > ------- > > `make check` on OSX. > > > Thanks, > > Greg Mann > >
