> On 五月 27, 2016, 9:39 a.m., Adam B wrote: > > src/tests/dynamic_weights_tests.cpp, line 88 > > <https://reviews.apache.org/r/47805/diff/2/?file=1396132#file1396132line88> > > > > Neat trick, but I think we're better off just specifying > > DEFAULT_CREDENTIAL at those call sites > > zhou xing wrote: > Adam, not very clear on your suggestions, do you mean that we just put > credential = DEFAULT_CREDENTIAL here? but as a macro, it is not allowed to > put an expression in this file scope, thanks for your time on looking this.
or do you mean change all the caller side to add the credential param and remove the param default value here? - zhou ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47805/#review135190 ----------------------------------------------------------- On 五月 27, 2016, 5:45 a.m., zhou xing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47805/ > ----------------------------------------------------------- > > (Updated 五月 27, 2016, 5:45 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: mesos-5335 > https://issues.apache.org/jira/browse/mesos-5335 > > > Repository: mesos > > > Description > ------- > > Add 'GET_WEIGHTS_WITH_ROLE' for the authorization of GET /weights. > > > Diffs > ----- > > docs/endpoints/master/weights.md 1e540795c5fb90c8ea957dd444b9e564e0b1ac23 > include/mesos/authorizer/acls.proto > ace9b698f46e1437911115c82324a87a0d7827fb > include/mesos/authorizer/authorizer.proto > 02d1a01d57cf34b38524f4368187878b03343537 > src/authorizer/local/authorizer.cpp > 3c7c791bde65cfcbcc4e319c9ccc487ab37d8029 > src/master/http.cpp b36b439a1fa07c52146deff2b90728f92676ade3 > src/master/master.hpp 1a875c32eddfb6d884e3d0dda7f5716ee53966c3 > src/master/weights_handler.cpp 4bc060fdb015df6658194eef92fe11b14aa15c79 > src/tests/dynamic_weights_tests.cpp > 362c59aae7b305710d5985bfec28f881be3b64b8 > > Diff: https://reviews.apache.org/r/47805/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > zhou xing > >
