> On 五月 29, 2016, 1:36 a.m., Vinod Kone wrote: > > src/files/files.cpp, line 374 > > <https://reviews.apache.org/r/46373/diff/8/?file=1386402#file1386402line374> > > > > Can we fix the pailer to not send -1 length in a follow up patch?
yes, will submit a patch then - zhou ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46373/#review135408 ----------------------------------------------------------- On 五月 18, 2016, 4:13 a.m., zhou xing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46373/ > ----------------------------------------------------------- > > (Updated 五月 18, 2016, 4:13 a.m.) > > > Review request for mesos, Benjamin Mahler and Greg Mann. > > > Bugs: mesos-5060 > https://issues.apache.org/jira/browse/mesos-5060 > > > Repository: mesos > > > Description > ------- > > [MESOS-5060] > The patch did the following changes: > 1. Fix the length logic in files.cpp. > 2. Add some tests to test the /files/read.json endponit with > negative length. > > > Diffs > ----- > > src/files/files.cpp e4b0ada00aabba6553810391f4015a896f8a69a5 > src/tests/files_tests.cpp 5d6620d13babaf0bb7f9c888bb1b4fa2228b6ccd > > Diff: https://reviews.apache.org/r/46373/diff/ > > > Testing > ------- > > make > make check > > request 'files/read.json' endpoint with negative offset or length argument > > > Thanks, > > zhou xing > >
