> On May 30, 2016, 3:08 a.m., Guangya Liu wrote: > > include/mesos/scheduler/scheduler.proto, line 270 > > <https://reviews.apache.org/r/46758/diff/1/?file=1364247#file1364247line270> > > > > Just a question here: Does it make sense to highlight that this is a > > `inverse offer fiter`? such as rename it to `inverse_filter`?
The concept behind the "filter" doesn't change even if it is acting on a different type of offer. In fact, adding an "inverse" to the filter might make it more confusing. Perhaps someone might read it as, "filter everything except this" :D - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46758/#review135489 ----------------------------------------------------------- On April 27, 2016, 6:22 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46758/ > ----------------------------------------------------------- > > (Updated April 27, 2016, 6:22 p.m.) > > > Review request for mesos, Anand Mazumdar, Joseph Wu, and Vinod Kone. > > > Bugs: MESOS-5296 > https://issues.apache.org/jira/browse/MESOS-5296 > > > Repository: mesos > > > Description > ------- > > V1 API: Split Accept/Decline for offers and Inverse Offers. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 078c6550f24a3d8ac675251168434130fc3eeef3 > include/mesos/v1/scheduler/scheduler.proto > 8ed9e19a9e5aa19a518b708b0e0d9cfdc038cd11 > src/master/validation.cpp f458100d22ec1f9f10921c1c91b6931a5671e28f > src/tests/master_maintenance_tests.cpp > 971c4473acbec5206614f46f51b06b3460595d50 > > Diff: https://reviews.apache.org/r/46758/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
