> On May 30, 2016, 9:32 a.m., Guangya Liu wrote: > > src/examples/test_http_framework.cpp, lines 130-131 > > <https://reviews.apache.org/r/46756/diff/1/?file=1364228#file1364228line130> > > > > What about adding a `TODO` here to clarify that we need some logic here > > to handle inverse offer just like what we did for `Event::OFFERS`?
This example doesn't seem to be meant to use all the features. I followed the pattern from the other events that it ignores. - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46756/#review135481 ----------------------------------------------------------- On April 28, 2016, 1:21 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46756/ > ----------------------------------------------------------- > > (Updated April 28, 2016, 1:21 a.m.) > > > Review request for mesos, Anand Mazumdar, Joseph Wu, and Vinod Kone. > > > Bugs: MESOS-5296 > https://issues.apache.org/jira/browse/MESOS-5296 > > > Repository: mesos > > > Description > ------- > > V1 API: Split Resource offers and Inverse Offers. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > 078c6550f24a3d8ac675251168434130fc3eeef3 > include/mesos/v1/scheduler/scheduler.proto > 8ed9e19a9e5aa19a518b708b0e0d9cfdc038cd11 > src/cli/execute.cpp 370e9f4924514077bb816c537261b9070658ddfb > src/examples/long_lived_framework.cpp > 4c9ba5fea2cc1eafa8ee942a505038c9b109ff65 > src/examples/test_http_framework.cpp > db0463d894e9f2fb964781d16f8c622ce8a507a5 > src/internal/evolve.hpp cff6b657a6d69ff9e7f7dedc965122a03a200da1 > src/internal/evolve.cpp 4ca2abacd75523de8fb4ffe69a9edd8627f512af > src/master/master.cpp ff41da3d077b65b44277e1bbae88c61b7bb88a3d > src/messages/messages.proto e0f1fca92d3ea8c29c095da31653c317873a934c > src/sched/sched.cpp a1ec280222689a05e9a0241ec5c84277a25b0866 > src/tests/master_maintenance_tests.cpp > 971c4473acbec5206614f46f51b06b3460595d50 > src/tests/mesos.hpp 0f6f541c5d2007a69ad5bd6e884235cd3c0c1be2 > > Diff: https://reviews.apache.org/r/46756/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
