----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45574/#review136248 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 150 - 156) <https://reviews.apache.org/r/45574/#comment201272> I see in this hashmap, the keys and values are exactly same, e.g., CGROUP_SUBSYSTEM_CPU_NAME is "cpu", CGROUP_SUBSYSTEM_CPUACCT_NAME is "cpuacct", etc. It is a bit strange to have same keys and values in a hashmap, maybe we should use hashset? - Qian Zhang On April 16, 2016, 6:28 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45574/ > ----------------------------------------------------------- > > (Updated April 16, 2016, 6:28 p.m.) > > > Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and > Kevin Klues. > > > Bugs: MESOS-5047 > https://issues.apache.org/jira/browse/MESOS-5047 > > > Repository: mesos > > > Description > ------- > > Add `PerfEventSubsystem` for cgroups unified isolator. > > > Diffs > ----- > > src/linux/perf.hpp 674d5f886ea41b939a8e48832ee6595a78b2f6ce > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/45574/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
