> On June 6, 2016, 2:47 p.m., Vinod Kone wrote: > > src/tests/authorization_tests.cpp, line 2106 > > <https://reviews.apache.org/r/48264/diff/1/?file=1406798#file1406798line2106> > > > > what do you mean by "is only allowed for `ANY`"? > > > > did you mean "matches an ACL whose Object is `ANY`" ?
matches has somehow overloaded semantics here (given the LocalAuthorizers matches/allows) and it actually matches ACLs whose Object is ANY or NONE, but is only allowed for ACLs whose Object is ANY. I will change the sentence to "is allowed for an ACL whose Object is ANY" - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48264/#review136259 ----------------------------------------------------------- On June 6, 2016, 8:19 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48264/ > ----------------------------------------------------------- > > (Updated June 6, 2016, 8:19 a.m.) > > > Review request for mesos, Adam B, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-5405 > https://issues.apache.org/jira/browse/MESOS-5405 > > > Repository: mesos > > > Description > ------- > > As MESOS-5405 changes the request.object > field to optional. We need to check that it only > matches an `ANY` ACL. > > > Diffs > ----- > > src/tests/authorization_tests.cpp 9e0f0b4f01ae6e466f6d44433a83edcebba4167a > > Diff: https://reviews.apache.org/r/48264/diff/ > > > Testing > ------- > > make check (OSX) + repeat new test 100 times > > > Thanks, > > Joerg Schad > >
