----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47806/#review136340 -----------------------------------------------------------
include/mesos/docker/spec.proto (line 44) <https://reviews.apache.org/r/47806/#comment201360> The namespace already contains `docker`, no need to prefix with Docker. I would have a top level Config struct: ``` message Config { message Auth { optional string auth; optional string email; } } ``` - Jie Yu On May 25, 2016, 1:33 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47806/ > ----------------------------------------------------------- > > (Updated May 25, 2016, 1:33 a.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-4938 > https://issues.apache.org/jira/browse/MESOS-4938 > > > Repository: mesos > > > Description > ------- > > Add docker config auth protobuf to docker spec. > > > Diffs > ----- > > include/mesos/docker/spec.proto 4f2ff2d7d88ceca2f25864b60a04ff5ec05317ff > > Diff: https://reviews.apache.org/r/47806/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
