> On June 7, 2016, 7:56 a.m., Benjamin Bannier wrote: > > support/cpplint.py, line 3376 > > <https://reviews.apache.org/r/48320/diff/1/?file=1408633#file1408633line3376> > > > > I think it makes sense to whitelist usage of `NULL` in comments. This > > would allow us to e.g., at times document how we interop with C code or use > > words like `NULLARY` in all caps.
IMHO it is easier/simpler to just blacklist NULL entirely. In the rare case you actually want to reference the NULL concept in a comment, you can use terms like "null pointer" (or the appropriate escape to cause cpplint to ignore the comment, I'd think). - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48320/#review136428 ----------------------------------------------------------- On June 7, 2016, 7:47 a.m., Tomasz Janiszewski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48320/ > ----------------------------------------------------------- > > (Updated June 7, 2016, 7:47 a.m.) > > > Review request for mesos, Benjamin Mahler, Michael Park, and Neil Conway. > > > Bugs: MESOS-3243 > https://issues.apache.org/jira/browse/MESOS-3243 > > > Repository: mesos > > > Description > ------- > > Update C++ style checker to prevent NULL usage. > > > Diffs > ----- > > support/cpplint.py 96e7fbcfe84067becbac89de909a2c6bdf99a60b > support/mesos-style.py 35ef7867c45afa02f0c74b86149f2e0489fe2d15 > > Diff: https://reviews.apache.org/r/48320/diff/ > > > Testing > ------- > > > Thanks, > > Tomasz Janiszewski > >
