----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48320/#review137508 -----------------------------------------------------------
Fix it, then Ship it! support/cpplint.py (line 1) <https://reviews.apache.org/r/48320/#comment202654> Not in this file, but do we need to update `cpplint.patch` as well? We seem to have stopped doing that at some point. support/cpplint.py (line 33) <https://reviews.apache.org/r/48320/#comment202653> @mpark: Do we need to update this here (e.g., for legal reasons)? I see you were the first one to stop doing that. support/cpplint.py (line 161) <https://reviews.apache.org/r/48320/#comment202650> Is it worth introducing an extra category for this? -- I think it might fit well into `build/`, e.g., as `build/nullptr`. support/mesos-style.py (line 48) <https://reviews.apache.org/r/48320/#comment202651> `s~c++11/null~build~c++/nullptr~` - Benjamin Bannier On June 7, 2016, 9:47 a.m., Tomasz Janiszewski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48320/ > ----------------------------------------------------------- > > (Updated June 7, 2016, 9:47 a.m.) > > > Review request for mesos, Benjamin Mahler, Michael Park, and Neil Conway. > > > Bugs: MESOS-3243 > https://issues.apache.org/jira/browse/MESOS-3243 > > > Repository: mesos > > > Description > ------- > > Update C++ style checker to prevent NULL usage. > > > Diffs > ----- > > support/cpplint.py 96e7fbcfe84067becbac89de909a2c6bdf99a60b > support/mesos-style.py 35ef7867c45afa02f0c74b86149f2e0489fe2d15 > > Diff: https://reviews.apache.org/r/48320/diff/ > > > Testing > ------- > > > Thanks, > > Tomasz Janiszewski > >
