----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48046/#review136664 -----------------------------------------------------------
src/master/http.cpp (lines 1390 - 1411) <https://reviews.apache.org/r/48046/#comment201762> so this stuff is duplicated in the REST handler and this handler. i wonder if we can factor it out as well into a common function. for example, can `_tasks()` take `limit`, `offset` and `order` as parameters and return a Future of Task* collection? - Vinod Kone On June 8, 2016, 7:18 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48046/ > ----------------------------------------------------------- > > (Updated June 8, 2016, 7:18 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5493 > https://issues.apache.org/jira/browse/MESOS-5493 > > > Repository: mesos > > > Description > ------- > > Implement v1::master::Call::GET_TASKS. > > > Diffs > ----- > > include/mesos/v1/master.proto 7b07b90557e0202cabc8f6164582a058631ab0e8 > src/master/http.cpp 4b2d1386e1ecb447b597a432f9df9adaa5c3aa37 > src/master/master.hpp 790da3ce686401c378ad9c62d497d60893c4ce41 > src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 > > Diff: https://reviews.apache.org/r/48046/diff/ > > > Testing > ------- > > make check on ubuntu 14.04 > > > Thanks, > > Jay Guo > >
