> On June 9, 2016, 9:26 p.m., Vinod Kone wrote:
> > src/tests/api_tests.cpp, line 171
> > <https://reviews.apache.org/r/48046/diff/4/?file=1411800#file1411800line171>
> >
> > What does this comment mean? I didn't follow.
> >
> > Also, comments should start with a capital letter and end in a period.
This line of code is intended to invoke `set_has_get_tasks()` (private method),
which is to toggle `GET_TASKS` bit.
```
inline void Call::set_has_get_tasks() {
_has_bits_[0] |= 0x00000020u;
}
```
However this line looks a bit weird, so I left the comment there. If you know
any other way to toggle the bit, let me know.
- Jay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48046/#review136822
-----------------------------------------------------------
On June 9, 2016, 12:49 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48046/
> -----------------------------------------------------------
>
> (Updated June 9, 2016, 12:49 a.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-5493
> https://issues.apache.org/jira/browse/MESOS-5493
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implement v1::master::Call::GET_TASKS.
>
>
> Diffs
> -----
>
> include/mesos/v1/master.proto 7b07b90557e0202cabc8f6164582a058631ab0e8
> src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7
> src/internal/evolve.cpp c255195b69f55f6429beed6c18a4a31b38528840
> src/master/http.cpp 4b2d1386e1ecb447b597a432f9df9adaa5c3aa37
> src/master/master.hpp 790da3ce686401c378ad9c62d497d60893c4ce41
> src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0
>
> Diff: https://reviews.apache.org/r/48046/diff/
>
>
> Testing
> -------
>
> make check on ubuntu 14.04
>
>
> Thanks,
>
> Jay Guo
>
>
