----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48434/#review136703 -----------------------------------------------------------
src/master/http.cpp (line 514) <https://reviews.apache.org/r/48434/#comment201819> this comment doesn't make sense in this helper function because it doesn't have a handle to the original http::Request. also, do we really need this helper considering this is a one liner? i'm thinking it's probably better to just inline it. src/master/http.cpp (line 591) <https://reviews.apache.org/r/48434/#comment201818> why the name change? src/master/http.cpp (line 1305) <https://reviews.apache.org/r/48434/#comment201820> if we don't have a helper, this will be ``` return OK(serialize(responseType, response), stringify(responseType)); ``` - Vinod Kone On June 8, 2016, 6:26 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48434/ > ----------------------------------------------------------- > > (Updated June 8, 2016, 6:26 p.m.) > > > Review request for mesos, Abhishek Dasgupta, zhou xing, and Vinod Kone. > > > Bugs: MESOS-5572 > https://issues.apache.org/jira/browse/MESOS-5572 > > > Repository: mesos > > > Description > ------- > > Changed operator API RPC handlers to `http::Response` in master. > > > Diffs > ----- > > src/master/http.cpp 4b2d1386e1ecb447b597a432f9df9adaa5c3aa37 > src/master/master.hpp 790da3ce686401c378ad9c62d497d60893c4ce41 > > Diff: https://reviews.apache.org/r/48434/diff/ > > > Testing > ------- > > Test by `./bin/mesos-tests.sh --gtest_filter="*MasterAPITest*"` > > > Thanks, > > haosdent huang > >
