> On June 8, 2016, 9:13 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 514 > > <https://reviews.apache.org/r/48434/diff/1/?file=1411441#file1411441line514> > > > > this comment doesn't make sense in this helper function because it > > doesn't have a handle to the original http::Request. > > > > also, do we really need this helper considering this is a one liner? > > i'm thinking it's probably better to just inline it.
Thank you so much for your review, just updated. May you help review again? Thank you in advance. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48434/#review136703 ----------------------------------------------------------- On June 9, 2016, 2 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48434/ > ----------------------------------------------------------- > > (Updated June 9, 2016, 2 a.m.) > > > Review request for mesos, Abhishek Dasgupta, zhou xing, and Vinod Kone. > > > Bugs: MESOS-5572 > https://issues.apache.org/jira/browse/MESOS-5572 > > > Repository: mesos > > > Description > ------- > > Changed operator API RPC handlers to `http::Response` in master. > > > Diffs > ----- > > src/master/http.cpp 4b2d1386e1ecb447b597a432f9df9adaa5c3aa37 > src/master/master.hpp 790da3ce686401c378ad9c62d497d60893c4ce41 > > Diff: https://reviews.apache.org/r/48434/diff/ > > > Testing > ------- > > Test by `./bin/mesos-tests.sh --gtest_filter="*MasterAPITest*"` > > > Thanks, > > haosdent huang > >
