----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48442/#review136708 -----------------------------------------------------------
Ship it! Can you add more details to the description on why `disconnected` callback is no longer called? - Vinod Kone On June 8, 2016, 7:39 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48442/ > ----------------------------------------------------------- > > (Updated June 8, 2016, 7:39 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > These expectations are no longer needed after MESOS-4029 since > we now explicitly destroy the scheduler process in the `TestMesos` > destructor. This ensures that there cannot be any unexpected > callbacks thereafter. Also, fixed a wrong expectation in > `Teardown` test. We explicitly close the socket now after > https://reviews.apache.org/r/44729/ > > > Diffs > ----- > > src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c > > Diff: https://reviews.apache.org/r/48442/diff/ > > > Testing > ------- > > make check (gtest_repeat=1000) no gmock warnings were generated > > > Thanks, > > Anand Mazumdar > >
