----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48442/#review136729 -----------------------------------------------------------
Patch looks great! Reviews applied: [48437, 48442] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 8, 2016, 9:37 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48442/ > ----------------------------------------------------------- > > (Updated June 8, 2016, 9:37 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > After the recent test refactorings we no longer invoke > `Shutdown()` at the end of the tests. This ensures that > the `Master` object is destroyed strictly _after_ the scheduler > library itself (MESOS-4029). This ensures that there cannot > be any unexpected callbacks thereafter. > > Also, fixed a wrong expectation in > `Teardown` test. We explicitly close the socket now after > https://reviews.apache.org/r/44729/ > > > Diffs > ----- > > src/tests/scheduler_tests.cpp d9cc3fde0caeadb16164e68ed66be098fd3ada7c > > Diff: https://reviews.apache.org/r/48442/diff/ > > > Testing > ------- > > make check (gtest_repeat=1000) no gmock warnings were generated > > > Thanks, > > Anand Mazumdar > >
