> On May 14, 2016, 3:59 a.m., haosdent huang wrote: > > 3rdparty/libprocess/src/tests/ssl_tests.cpp, line 736 > > <https://reviews.apache.org/r/47362/diff/1/?file=1383164#file1383164line736> > > > > Have a question here, why settle and resume without any operations here?
It was to ensure that the socket connection remains pending (the condition we check right after settling), it's technically not enough to reliably catch it (I'll document that). > On May 14, 2016, 3:59 a.m., haosdent huang wrote: > > 3rdparty/libprocess/src/tests/ssl_tests.cpp, line 755 > > <https://reviews.apache.org/r/47362/diff/1/?file=1383164#file1383164line755> > > > > I think should change to > > > > ``` > > const string buffer = > > string("HTTP/1.1 200 OK\r\n") + > > "Content-Length : " + > > stringify(data.length()) + "\r\n" + > > "\r\n" + > > data; > > ``` > > > > here? I originally had this but I found it less readable to indent the first line of the response due to the string construction. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47362/#review133250 ----------------------------------------------------------- On May 13, 2016, 9:46 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47362/ > ----------------------------------------------------------- > > (Updated May 13, 2016, 9:46 p.m.) > > > Review request for mesos, Alexander Rukletsov, Joris Van Remoortere, and Neil > Conway. > > > Bugs: MESOS-5340 > https://issues.apache.org/jira/browse/MESOS-5340 > > > Repository: mesos > > > Description > ------- > > This test works by creating a connection on which no data is sent (the SSL > handshake does not complete, nor is the socket downgraded). After which, we > expect that an HTTP request should succeed. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/ssl_tests.cpp > 4d237815a03828b915e821c3af78132e2915c610 > > Diff: https://reviews.apache.org/r/47362/diff/ > > > Testing > ------- > > This test fails before the fix in MESOS-5340. > > ``` > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from SSLTest > [ RUN ] SSLTest.SilentSocket > ../../../3rdparty/libprocess/src/tests/ssl_tests.cpp:752: Failure > Failed to wait 15secs for socket > [ FAILED ] SSLTest.SilentSocket (15221 ms) > [----------] 1 test from SSLTest (15221 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (15222 ms total) > [ PASSED ] 0 tests. > [ FAILED ] 1 test, listed below: > [ FAILED ] SSLTest.SilentSocket > ``` > > > Thanks, > > Benjamin Mahler > >
