----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/#review136895 -----------------------------------------------------------
Content LGTM, but the return types are inconsistent with other operator API return types. src/master/http.cpp (lines 3275 - 3278) <https://reviews.apache.org/r/48084/#comment202001> I probably missed a discussion elsewhere... Aren't all (master) operator API's supposed to return `v1::master::Response`? - Joseph Wu On June 9, 2016, 10:49 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48084/ > ----------------------------------------------------------- > > (Updated June 9, 2016, 10:49 a.m.) > > > Review request for mesos, Joseph Wu and Vinod Kone. > > > Bugs: MESOS-5503 > https://issues.apache.org/jira/browse/MESOS-5503 > > > Repository: mesos > > > Description > ------- > > Implemented v1::master::Call::GET_MAINTENANCE_STATUS. > > > Diffs > ----- > > src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 > src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b > src/master/http.cpp 6e1bf9557a854a89fa9173223295816a9e114e7c > src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb > > Diff: https://reviews.apache.org/r/48084/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
