----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47668/#review137088 -----------------------------------------------------------
src/launcher/executor.cpp (line 474) <https://reviews.apache.org/r/47668/#comment202254> Can you add a NOTE here saying that we need to put change user, chdir logics in command executor because these depend on the new root filesystem. If the command task does not change root fiesystem, these will be handled in the containerizer. src/launcher/executor.cpp (lines 485 - 492) <https://reviews.apache.org/r/47668/#comment202250> Let's simply assume that container user does not exist. Please add a TODO here to handle the case where contianer user exists. src/launcher/executor.cpp (lines 549 - 570) <https://reviews.apache.org/r/47668/#comment202251> I would move that up right below fs::enter src/slave/containerizer/mesos/launch.cpp (lines 229 - 236) <https://reviews.apache.org/r/47668/#comment202256> Let's remove the logic here simply assume that container user does not exist. Add a TODO here as I suggested above. - Jie Yu On May 26, 2016, 8:55 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47668/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 8:55 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin > Klues, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Obtained uid/gids before changing filesystem root. > > > Diffs > ----- > > src/launcher/executor.cpp e4c3b75b647b54ffecedfdfa34fb3925f686c0c7 > src/slave/containerizer/mesos/launch.cpp > e22106b014c871e2184a15c2ab154a0674874e47 > > Diff: https://reviews.apache.org/r/47668/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
