----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/#review137128 -----------------------------------------------------------
src/internal/evolve.cpp (line 445) <https://reviews.apache.org/r/48585/#comment202286> Hi, @anandmazumdar, @dongdong, @guoger, @vinodkone I have a question here, should I move this out of `evolve.cpp` and create some file to put `Try<mesos::master::Response> parse(const JSON::Object& json);`? src/master/http.cpp (line 1298) <https://reviews.apache.org/r/48585/#comment202287> @anandmazumdar, @dongdong, @guoger, @vinodkone Another question is should I evolve the response to v1 before call `serialize`? - haosdent huang On June 11, 2016, 5:20 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48585/ > ----------------------------------------------------------- > > (Updated June 11, 2016, 5:20 p.m.) > > > Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone. > > > Bugs: MESOS-5593 > https://issues.apache.org/jira/browse/MESOS-5593 > > > Repository: mesos > > > Description > ------- > > Devolved v1 operator protos to unversioned operator protos in Master. > > > Diffs > ----- > > src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 > src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408 > src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 > src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b > src/master/http.cpp 6e1bf9557a854a89fa9173223295816a9e114e7c > src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb > src/master/validation.hpp e1271bbaebaac52a078eedfdc2299c7c6f4474f8 > src/master/validation.cpp 7b9c2281b2ab1295211f0dd385cd77947fbd63be > > Diff: https://reviews.apache.org/r/48585/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
