----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/#review137149 -----------------------------------------------------------
Fix it, then Ship it! LGTM.. Just a few more nits to clean up... src/internal/devolve.hpp (line 30) <https://reviews.apache.org/r/48585/#comment202304> Why do we need this include for this patch? src/internal/devolve.hpp (line 32) <https://reviews.apache.org/r/48585/#comment202309> Bring this above the `mesos.hpp` include. src/master/http.cpp (line 578) <https://reviews.apache.org/r/48585/#comment202306> Micro Nit: remove `mesos::`, just `master::Call` should suffice. src/master/http.cpp (lines 1298 - 1299) <https://reviews.apache.org/r/48585/#comment202307> Let's just do this inline as per my earlier comment: ```cpp return OK(serialize(responseContentType, evolve<v1::master::Response::GET_FLAGS>(_flags())), stringify(responseContentType)); ``` The reasoning being that we should not have `v1::` response variables in our internal functions and leave that business logic to the `evolve` functions. Sound good? src/master/master.hpp (line 47) <https://reviews.apache.org/r/48585/#comment202308> Can we get rid of this now that we don't use the `v1` headers in our internal code. - Anand Mazumdar On June 12, 2016, 4:15 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48585/ > ----------------------------------------------------------- > > (Updated June 12, 2016, 4:15 a.m.) > > > Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone. > > > Bugs: MESOS-5593 > https://issues.apache.org/jira/browse/MESOS-5593 > > > Repository: mesos > > > Description > ------- > > Devolved v1 operator protos to unversioned operator protos in Master. > > > Diffs > ----- > > src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 > src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408 > src/internal/evolve.hpp 66a3deaa94939ad2233d944ba35ac7e5cbe682e7 > src/internal/evolve.cpp 7f16cbda7da6c838648cca909368973e7298730b > src/master/http.cpp 6e1bf9557a854a89fa9173223295816a9e114e7c > src/master/master.hpp 2c45dab291a153b42809ab12e4252bf58559feeb > src/master/validation.hpp e1271bbaebaac52a078eedfdc2299c7c6f4474f8 > src/master/validation.cpp 7b9c2281b2ab1295211f0dd385cd77947fbd63be > > Diff: https://reviews.apache.org/r/48585/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
