----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47663/#review137523 -----------------------------------------------------------
include/mesos/slave/isolator.proto (lines 30 - 31) <https://reviews.apache.org/r/47663/#comment202669> Not urs, but I think that we need to adjust the format of the proto as message xxxx { } by putting `{` in same line as `message`. Ditto as following. We can handle this in a separate patch. include/mesos/slave/isolator.proto (lines 131 - 139) <https://reviews.apache.org/r/47663/#comment202671> I saw that from https://github.com/docker/docker/blob/master/image/spec/v1.md#container-runconfig-field-descriptions, all of those info belong to `user`. Does it make sense to put `user` to a message proto? message UserInfo { // The user name or UID in the container. If 'user' is numerical, // it is an UID. Otherwise, it is an username. optional string user = 7; // The group name or GID in the container. If 'group' is numerical, // it is a GID. Otherwise, it is a groupname. optional string group = 8; // TODO: Add repeated supplementary groups. } message ContainerLaunchInfo { ... optional UserInfo user = 7; } - Guangya Liu On 六月 13, 2016, 11:47 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47663/ > ----------------------------------------------------------- > > (Updated 六月 13, 2016, 11:47 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin > Klues, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Added image user to 'ContainerLaunchInfo'. > > > Diffs > ----- > > include/mesos/slave/isolator.proto 60a9bb637e12593a97ed1a7c510ebccd4e5a9615 > > Diff: https://reviews.apache.org/r/47663/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
