----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/#review137677 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 74) <https://reviews.apache.org/r/46158/#comment202874> Can you please clarfiy why we want to have `user` as a field of `Info` class? Basically, I do not think `Info` class should have such field. src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 425) <https://reviews.apache.org/r/46158/#comment202876> Can you please clarify why we need the `pid` field in the `Info` class? This is the only place I see we assign value to `Info::pid`, but it seems we never use this field? Basically, I do not think we should have such field in `Info` class. src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 511) <https://reviews.apache.org/r/46158/#comment202870> Can you please clarify why we need the `resources` field in the `Info` class? This is the only place I see we assign value to `Info::resources`, but it seems we never use this field? Basically, I do not think we should have such field in `Info` class. - Qian Zhang On April 16, 2016, 6:14 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46158/ > ----------------------------------------------------------- > > (Updated April 16, 2016, 6:14 p.m.) > > > Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, and > Kevin Klues. > > > Bugs: MESOS-5041 > https://issues.apache.org/jira/browse/MESOS-5041 > > > Repository: mesos > > > Description > ------- > > Completed implementation of the cgroups unified isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46158/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
