> On June 11, 2016, 2:31 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 141 > > <https://reviews.apache.org/r/46158/diff/2/?file=1347650#file1347650line141> > > > > I would suggest to rename this method to `prepareHierarchy()`, the > > word `get` usually means this is a read-only method, but I think this is > > not a read-only method, we may do some write operations, e.g., mount > > subsystem, create root cgroup. > > > > And I know there is already a method in this class named > > `prepareHierarchy()`, I would suggest to rename it to `createCgroup()` > > because the intent of that method is to create cgroup for a specific > > container, right?
Make sense! - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/#review136998 ----------------------------------------------------------- On June 19, 2016, 3:55 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46158/ > ----------------------------------------------------------- > > (Updated June 19, 2016, 3:55 p.m.) > > > Review request for mesos, Gilbert Song, Guangya Liu, Ian Downes, Jie Yu, > Kevin Klues, and Qian Zhang. > > > Bugs: MESOS-5041 > https://issues.apache.org/jira/browse/MESOS-5041 > > > Repository: mesos > > > Description > ------- > > Completed implementation of the cgroups unified isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/46158/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
