----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47660/#review137757 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On June 14, 2016, 11:27 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47660/ > ----------------------------------------------------------- > > (Updated June 14, 2016, 11:27 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, James Peach, Kevin > Klues, and Timothy Chen. > > > Bugs: MESOS-4757 > https://issues.apache.org/jira/browse/MESOS-4757 > > > Repository: mesos > > > Description > ------- > > Since the 'user' in 'FrameworkInfo' is a required field, > so 'fromeworkInfo.has_user()' is always true. Currently > in our semantics, if the operator specifies the framework > user as an empty string, mesos will automagically set it > as the current host user. So the slave will always obtain > the user from 'FrameworkInfo', and 'switch_user' defaults > to be true from agent flag. We would prefer not to change > this semantics because a long deprecation cycle is needed. > So in this patch, we just fix the redundant check in slave > 'getExecutorInfo' logic. > > > Diffs > ----- > > src/slave/slave.cpp 0af04d6fe53f92e03905fb7b3bec72b09d5e8e57 > > Diff: https://reviews.apache.org/r/47660/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
