----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48584/#review137843 -----------------------------------------------------------
src/Makefile.am (line 220) <https://reviews.apache.org/r/48584/#comment203021> so the unversioned master.proto file is at `include/mesos/master/master.proto` whereas the versioned one is at `include/mesos/v1/master.proto`. we should either move the former to `include/mesos/master.proto` or the latter to `include/mesos/v1/master/master.proto`. we originially put the versioned proto at v1/master.proto instead of v1/master/master.proto because the base directory path indicated the API endpoint, but i'm ok moving it to v1/master/master.proto. same with agent. - Vinod Kone On June 15, 2016, 2:26 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48584/ > ----------------------------------------------------------- > > (Updated June 15, 2016, 2:26 p.m.) > > > Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone. > > > Bugs: MESOS-5593 > https://issues.apache.org/jira/browse/MESOS-5593 > > > Repository: mesos > > > Description > ------- > > Added unversioned protos for master API. > > > Diffs > ----- > > include/mesos/master/master.hpp PRE-CREATION > include/mesos/master/master.proto PRE-CREATION > src/Makefile.am f672fc9d2b58e785c65e21a4e52c60c04ce2498a > > Diff: https://reviews.apache.org/r/48584/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
