> On June 15, 2016, 9:05 p.m., Vinod Kone wrote: > > src/Makefile.am, line 220 > > <https://reviews.apache.org/r/48584/diff/3/?file=1419944#file1419944line220> > > > > so the unversioned master.proto file is at > > `include/mesos/master/master.proto` whereas the versioned one is at > > `include/mesos/v1/master.proto`. we should either move the former to > > `include/mesos/master.proto` or the latter to > > `include/mesos/v1/master/master.proto`. we originially put the versioned > > proto at v1/master.proto instead of v1/master/master.proto because the base > > directory path indicated the API endpoint, but i'm ok moving it to > > v1/master/master.proto. > > > > same with agent. > > haosdent huang wrote: > Compare current protobuf folder structure, > ``` > include/mesos/v1/agent.proto > include/mesos/v1/master.proto > include/mesos/v1/mesos.proto > ``` > vs > ``` > include/mesos/v1/executor/executor.proto > include/mesos/v1/maintenance/maintenance.proto > include/mesos/v1/master/allocator.proto > include/mesos/v1/quota/quota.proto > include/mesos/v1/scheduler/scheduler.proto > ``` > I prefer move `include/mesos/v1/agent.proto` to > `include/mesos/v1/agent/agent.proto`, `include/mesos/v1/master.proto` to > `include/mesos/v1/master/master.proto`. > Let me post a patch for this.
Posted at https://reviews.apache.org/r/48799/ - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48584/#review137843 ----------------------------------------------------------- On June 16, 2016, 5:11 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48584/ > ----------------------------------------------------------- > > (Updated June 16, 2016, 5:11 p.m.) > > > Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone. > > > Bugs: MESOS-5593 > https://issues.apache.org/jira/browse/MESOS-5593 > > > Repository: mesos > > > Description > ------- > > Added unversioned protos for master API. > > > Diffs > ----- > > include/mesos/master/master.hpp PRE-CREATION > include/mesos/master/master.proto PRE-CREATION > src/Makefile.am 90b6c033054a09e9fbad9066e0763113a13a4d09 > > Diff: https://reviews.apache.org/r/48584/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
