----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48268/#review138170 -----------------------------------------------------------
src/Makefile.am (line 693) <https://reviews.apache.org/r/48268/#comment203381> I think you want put ``` $(top_srcdir)/include/mesos/v1/quota/quota.hpp \ ``` here, right? ;-) src/Makefile.am (line 694) <https://reviews.apache.org/r/48268/#comment203382> No your problem, but I think this is the error before. Could you remove ``` ../include/mesos/v1/master/allocator.pb.h ``` because we have define it in `nodist_v1master_HEADERS` src/internal/devolve.hpp (line 28) <https://reviews.apache.org/r/48268/#comment203383> Put this above ``` #include <mesos/scheduler/scheduler.hpp> ``` src/internal/devolve.hpp (line 36) <https://reviews.apache.org/r/48268/#comment203384> Put this above ``` #include <mesos/v1/quota/quota.hpp> ``` src/internal/devolve.hpp (line 59) <https://reviews.apache.org/r/48268/#comment203385> May you rebase and remove unnecessary changes in devolve.cpp/devolve.hpp because MESOS-5593 just resolved? :-) src/master/http.cpp (line 677) <https://reviews.apache.org/r/48268/#comment203386> indent incorrect here. src/master/master.hpp (line 1040) <https://reviews.apache.org/r/48268/#comment203387> indent incorrect here. - haosdent huang On June 16, 2016, 11:14 a.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48268/ > ----------------------------------------------------------- > > (Updated June 16, 2016, 11:14 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5509 > https://issues.apache.org/jira/browse/MESOS-5509 > > > Repository: mesos > > > Description > ------- > > Implemented SET_QUOTA Call in v1 master API. > > > Diffs > ----- > > include/mesos/v1/master.proto 7b07b90557e0202cabc8f6164582a058631ab0e8 > include/mesos/v1/quota/quota.hpp PRE-CREATION > src/Makefile.am 90b6c033054a09e9fbad9066e0763113a13a4d09 > src/internal/devolve.hpp 00842bb0de1dd587f2b47c79f17c0e7bd7f51189 > src/internal/devolve.cpp 4233246c6838f85189f1b4c7e66d2bc0a3bf5408 > src/master/http.cpp db625f0d656f207a89fcc14b18ae2fc31d30e673 > src/master/master.hpp a0944ddccd3a4b33458cd2489bb5fcdbbdc55720 > src/master/quota_handler.cpp 7eeb60ed08deb2d7139423716e70e9acc92a0416 > src/tests/api_tests.cpp 3a482ca2a640b3f3e3b08a80ac84068d7e9ff8b0 > > Diff: https://reviews.apache.org/r/48268/diff/ > > > Testing > ------- > > On Ubuntu 16.04: > sudo GTEST_FILTER="*MasterAPITest.SetQuota*" make -j4 check > > [==========] Running 2 tests from 1 test case. > [----------] Global test environment set-up. > [----------] 2 tests from ContentType/MasterAPITest > [ RUN ] ContentType/MasterAPITest.SetQuota/0 > [ OK ] ContentType/MasterAPITest.SetQuota/0 (129 ms) > [ RUN ] ContentType/MasterAPITest.SetQuota/1 > [ OK ] ContentType/MasterAPITest.SetQuota/1 (98 ms) > [----------] 2 tests from ContentType/MasterAPITest (227 ms total) > > [----------] Global test environment tear-down > [==========] 2 tests from 1 test case ran. (236 ms total) > [ PASSED ] 2 tests. > > > Thanks, > > Abhishek Dasgupta > >
