----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48885/#review138327 -----------------------------------------------------------
Very nice! src/webui/master/static/agents.html (lines 16 - 19) <https://reviews.apache.org/r/48885/#comment203495> Just a note, we traditionally called the amount of allocated resources "used" as you did in your commit summary (and it's still called "used" in the master metrics). However, we now prefer "allocated" because "used" tends to suggest the portion of the allocation that is in use within the container. Note that the agent page of the UI now shows `CPUS (Used / Allocated)` for tasks and executors. To keep consistent and to be clear about which numbers we're showing here, could you do the following? ``` <th data-key="resources.cpus">CPUs (Allocated / Total)</th> <th data-key="resources.gpus">GPUs (Allocated / Total)</th> <th data-key="resources.mem">Mem (Allocated / Total)</th> <th data-key="resources.disk">Disk (Allocated / Total)</th> ``` src/webui/master/static/agents.html (line 39) <https://reviews.apache.org/r/48885/#comment203496> Progress bars look neat! However, I'd suggest having this patch only introduce the allocation information into the table, and add progress bars in a separate patch. I suggest this because adding progress bars only here seems inconsistent (i.e. why don't the agent level pages (e.g. agent_framework.html) have progress bars?) - Benjamin Mahler On June 17, 2016, 10:06 p.m., Tomasz Janiszewski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48885/ > ----------------------------------------------------------- > > (Updated June 17, 2016, 10:06 p.m.) > > > Review request for mesos, Benjamin Mahler, haosdent huang, and Vinod Kone. > > > Bugs: MESOS-5636 > https://issues.apache.org/jira/browse/MESOS-5636 > > > Repository: mesos > > > Description > ------- > > Display used Agents resources in webui. > > > Diffs > ----- > > src/webui/master/static/agents.html > 98da21dad90460276a48b49c2792264db849739b > src/webui/master/static/css/mesos.css > 5b1227e9d64757f9fc106e497f7fa3ed72112c10 > > Diff: https://reviews.apache.org/r/48885/diff/ > > > Testing > ------- > >  > > > Thanks, > > Tomasz Janiszewski > >
