> On June 17, 2016, 10:19 p.m., Benjamin Mahler wrote: > > Very nice! > > Tomasz Janiszewski wrote: > @bmahler Thanks for review. I fixed issues. Would you mind take a look > once again. > BTW: I saw your > [todo](https://github.com/apache/mesos/blob/9838d27812005d0d935a72433fbc68d027c7931e/src/master/http.cpp#L451). > Is it right placed? Frameworks allocated resources are presented while > Agents are not.
I'm not sure, it appears to have been introduced by Michael here: ``` commit e8af5cca9bbc7e0ab96749e42b584c09554b2347 Author: Michael Park <mp...@apache.org> Date: Tue Dec 8 09:25:43 2015 -0500 Updated `Master::Http::state` to use `jsonify` in mesos. Review: https://reviews.apache.org/r/41595/ ``` And it was likely copied from somewhere else, it should be removed. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48885/#review138327 ----------------------------------------------------------- On June 17, 2016, 10:37 p.m., Tomasz Janiszewski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48885/ > ----------------------------------------------------------- > > (Updated June 17, 2016, 10:37 p.m.) > > > Review request for mesos, Benjamin Mahler, haosdent huang, and Vinod Kone. > > > Bugs: MESOS-5636 > https://issues.apache.org/jira/browse/MESOS-5636 > > > Repository: mesos > > > Description > ------- > > Display allocated Agents resources in webui. > > > Diffs > ----- > > src/webui/master/static/agents.html > 98da21dad90460276a48b49c2792264db849739b > > Diff: https://reviews.apache.org/r/48885/diff/ > > > Testing > ------- > > ![/agents](https://issues.apache.org/jira/secure/attachment/12811483/mesos_agents_webui.png) > > > Thanks, > > Tomasz Janiszewski > >