----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48056/#review138724 -----------------------------------------------------------
Fix it, then Ship it! Managed to build on Windows 8, but we can keep the prerequisite version 10+. After inspecting the website-rendered version, there are a couple things we can massage to make the instructions look better. docs/getting-started.md (line 29) <https://reviews.apache.org/r/48056/#comment203912> s/sources/source/ docs/getting-started.md (lines 174 - 176) <https://reviews.apache.org/r/48056/#comment203915> Change these links to use `[text](href)` syntax. Also, can you change these to a numbered list? i.e. 1. Install VS 2. Install CMake 3. Install Patch docs/getting-started.md (lines 178 - 180) <https://reviews.apache.org/r/48056/#comment203919> These notes can be interleaved with the appropriate downloads above. (i.e. the user should do installations in order) docs/getting-started.md (line 182) <https://reviews.apache.org/r/48056/#comment203920> Add `(Posix)` here (assuming `Windows != Posix` is general knowledge). We don't want to follow these steps on Windows. docs/getting-started.md (lines 204 - 205) <https://reviews.apache.org/r/48056/#comment203922> Add a note about bootstrap here: ``` # If you are developing on Windows, we recommend running the bootstrap. # This requires administrator privileges. $ ./bootstrap.bat ``` docs/getting-started.md (lines 219 - 221) <https://reviews.apache.org/r/48056/#comment203926> Add a note that the "PreferredToolArchitecture" can be set system-wide via Control Panel. I would also put this text block above the `msbuild ...` line. - Joseph Wu On June 20, 2016, 3:25 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48056/ > ----------------------------------------------------------- > > (Updated June 20, 2016, 3:25 p.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris > Van Remoortere, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Windows: Added build and run instructions. > > > Diffs > ----- > > docs/getting-started.md 8c72e5ec1263adb8792c8c49ede50bbf649e1ef3 > > Diff: https://reviews.apache.org/r/48056/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Pravat > >
