----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48991/#review138760 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 1493) <https://reviews.apache.org/r/48991/#comment203968> Can we use `LOG` here. This is a helper process, not the Agent process, not sure if `glog` has been initialized in the helper process. Since we are using `cerr` to log output from helper process should we use `cerr` with a (WARNING) tag? src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (line 1495) <https://reviews.apache.org/r/48991/#comment203967> You don't need `endl` for LOG - Avinash sridharan On June 21, 2016, 2:46 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48991/ > ----------------------------------------------------------- > > (Updated June 21, 2016, 2:46 a.m.) > > > Review request for mesos, Avinash sridharan, Guangya Liu, Artem Harutyunyan, > Jie Yu, and Qian Zhang. > > > Bugs: MESOS-5669 > https://issues.apache.org/jira/browse/MESOS-5669 > > > Repository: mesos > > > Description > ------- > > Added exception for etc hostname mount in cni isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 9fc709e95ecff7e97e159ed05a4efcf4e887d5e0 > > Diff: https://reviews.apache.org/r/48991/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
